fix: read skill files as UTF-8 - #26
Conversation
|
Codex review: needs maintainer review before merge. Reviewed July 2, 2026, 4:51 AM ET / 08:51 UTC. Summary Reproducibility: yes. for source-level reproduction: current main reads skill files with Ruby's default external encoding, and the PR body shows the C-locale validator path succeeding after the fix. I did not execute the validator because this review is read-only and must not create checkout artifacts. Review metrics: none identified. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Next step before merge
Security Review detailsBest possible solution: Merge the narrow UTF-8 read fix after ordinary maintainer review, keeping the validator behavior unchanged except for explicit file encoding. Do we have a high-confidence way to reproduce the issue? Yes for source-level reproduction: current main reads skill files with Ruby's default external encoding, and the PR body shows the C-locale validator path succeeding after the fix. I did not execute the validator because this review is read-only and must not create checkout artifacts. Is this the best way to solve the issue? Yes. Passing AGENTS.md: not found in the target repository. Codex review notes: model internal, reasoning high; reviewed against 2fe30c0dbef7. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
Summary
SKILL.mdfiles with explicit UTF-8 encoding inscripts/validate-skillsValidation
scripts/validate-skillsenv LC_ALL=C LANG=C scripts/validate-skillsgit diff --checkProof for the C-locale path after this patch:
Note: full CI browser-helper build was not run locally because
bunis not installed in this environment.